Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles check to views::train_schedule #8436

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Aug 13, 2024

Part of #8446

@hamz2a hamz2a requested a review from a team as a code owner August 13, 2024 09:29
@hamz2a hamz2a requested review from Wadjetz and flomonster August 13, 2024 09:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.07937% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (b58bc6b) to head (5d54097).
Report is 1 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/train_schedule.rs 66.12% 21 Missing ⚠️
editoast/src/views/v2/train_schedule/projection.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8436   +/-   ##
=========================================
  Coverage     36.83%   36.84%           
  Complexity     2169     2169           
=========================================
  Files          1280     1280           
  Lines        118678   118739   +61     
  Branches       3184     3184           
=========================================
+ Hits          43720    43747   +27     
- Misses        73075    73109   +34     
  Partials       1883     1883           
Flag Coverage Δ
core 74.86% <ø> (ø)
editoast 66.10% <65.07%> (-0.05%) ⬇️
front 15.84% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a requested a review from leovalais August 16, 2024 08:27
editoast/editoast_authz/src/builtin_role.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-add-roles-check-to-views-train-schedule branch from fd6bfbb to 9ffa8dd Compare August 21, 2024 09:08
@hamz2a hamz2a requested a review from leovalais August 21, 2024 09:12
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding my previous comments, you need both the roles for infra and timetable. Likewise for projection.

@hamz2a hamz2a force-pushed the hai/editoast-add-roles-check-to-views-train-schedule branch from 9ffa8dd to 5d54097 Compare August 21, 2024 14:14
@hamz2a hamz2a requested a review from leovalais August 21, 2024 14:15
@hamz2a hamz2a mentioned this pull request Aug 21, 2024
28 tasks
@hamz2a hamz2a added this pull request to the merge queue Aug 21, 2024
Merged via the queue into dev with commit e5ceb84 Aug 21, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-roles-check-to-views-train-schedule branch August 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants