Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: upgrade @reduxjs/toolkit #9099

Merged
merged 1 commit into from
Oct 1, 2024
Merged

front: upgrade @reduxjs/toolkit #9099

merged 1 commit into from
Oct 1, 2024

Conversation

emersion
Copy link
Member

rtk-query now always returns the "data" field in the object, but it may be undefined:

{ data: PostInfraByInfraIdApiResponse; error?: undefined; } | { data?: undefined; error: ApiError | SerializedError; }

Thus 'data' in response will always be true.

front/yarn.lock Show resolved Hide resolved
rtk-query now always returns the "data" field in the object, but
it may be undefined:

    { data: PostInfraByInfraIdApiResponse; error?: undefined; } | { data?: undefined; error: ApiError | SerializedError; }

Thus `'data' in response` will always be true.

Signed-off-by: Simon Ser <[email protected]>
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion added this pull request to the merge queue Oct 1, 2024
Merged via the queue into dev with commit 27c09eb Oct 1, 2024
24 checks passed
@emersion emersion deleted the emr/upgrade-rtk branch October 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants