Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: hard code feight rs & modify rs suggestion label #9305

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 11, 2024

closes #9301

@clarani clarani requested a review from a team as a code owner October 11, 2024 09:18
@clarani clarani force-pushed the cni/9301-hard-code-feight-rs branch from b1886c1 to ad36727 Compare October 11, 2024 09:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.92248% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.16%. Comparing base (5c58af7) to head (8bd742a).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...odules/rollingStock/hooks/useFilterRollingStock.ts 25.00% 12 Missing ⚠️
...c/applications/stdcmV2/components/StdcmConsist.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9305      +/-   ##
============================================
+ Coverage     38.55%   39.16%   +0.61%     
- Complexity     2244     2245       +1     
============================================
  Files          1288     1290       +2     
  Lines         98454    97244    -1210     
  Branches       3273     3280       +7     
============================================
+ Hits          37956    38084     +128     
+ Misses        58561    57221    -1340     
- Partials       1937     1939       +2     
Flag Coverage Δ
core 74.94% <ø> (+0.06%) ⬆️
editoast 72.39% <ø> (-0.06%) ⬇️
front 10.34% <89.92%> (+0.21%) ⬆️
gateway 2.50% <ø> (+0.30%) ⬆️
osrdyne 3.52% <ø> (+1.08%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9301-hard-code-feight-rs branch from ad36727 to c76c10d Compare October 11, 2024 09:23
@clarani clarani force-pushed the cni/9301-hard-code-feight-rs branch from c76c10d to e4b2037 Compare October 11, 2024 13:59
@clarani clarani force-pushed the cni/9301-hard-code-feight-rs branch from e4b2037 to 8bd742a Compare October 11, 2024 14:00
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@clarani clarani enabled auto-merge October 11, 2024 14:45
@clarani clarani added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit 676542a Oct 11, 2024
24 checks passed
@clarani clarani deleted the cni/9301-hard-code-feight-rs branch October 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: hard code the rolling stocks used for the freight companies
4 participants