Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: clean scenario page #9408

Merged
merged 3 commits into from
Oct 28, 2024
Merged

front: clean scenario page #9408

merged 3 commits into from
Oct 28, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 21, 2024

closes #9407

Changes

  • background color of the main components of SimulationResults
  • style of the map: add border radius and box-shadow, remove useless divs
  • small improvements on the margins

Before:
image
image
image

After:
image
image
image

@clarani clarani requested a review from a team as a code owner October 21, 2024 15:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (bae2942) to head (df97217).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 17 Missing and 1 partial ⚠️
...ents/SimulationResultsMap/SimulationResultsMap.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9408      +/-   ##
============================================
- Coverage     39.62%   39.62%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1300     1300              
  Lines         99158    99153       -5     
  Branches       3282     3282              
============================================
- Hits          39294    39290       -4     
+ Misses        57931    57930       -1     
  Partials       1933     1933              
Flag Coverage Δ
core 75.07% <ø> (ø)
editoast 73.29% <ø> (-0.02%) ⬇️
front 10.23% <0.00%> (+<0.01%) ⬆️
gateway 2.19% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani requested a review from SharglutDev October 21, 2024 15:51
@clarani clarani force-pushed the cni/9407-clean-scenario-page branch from f1f4452 to 7a2c127 Compare October 21, 2024 15:52
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this needs to be done in this PR, but we could also swap the position between the output table and the map.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. As there is nothing in the issue, not sure what you planned to fix here and if my comments are pertinent. But as you started to change some styles, I followed your lead :)

@clarani clarani force-pushed the cni/9407-clean-scenario-page branch from c37c802 to 8b74257 Compare October 23, 2024 07:32
@theocrsb
Copy link
Contributor

theocrsb commented Oct 23, 2024

The left spacing of the map is good but now we need to align all item with it 🙂
image

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@clarani clarani force-pushed the cni/9407-clean-scenario-page branch from e70742a to a3c0778 Compare October 24, 2024 10:23
@clarani clarani enabled auto-merge October 24, 2024 10:24
@clarani clarani force-pushed the cni/9407-clean-scenario-page branch 2 times, most recently from 45bd27f to da60413 Compare October 25, 2024 13:05
@clarani clarani force-pushed the cni/9407-clean-scenario-page branch from da60413 to 346fabe Compare October 28, 2024 14:27
@clarani clarani force-pushed the cni/9407-clean-scenario-page branch from 8ff3ce8 to df97217 Compare October 28, 2024 15:58
@clarani clarani added this pull request to the merge queue Oct 28, 2024
Merged via the queue into dev with commit 79ba07e Oct 28, 2024
24 checks passed
@clarani clarani deleted the cni/9407-clean-scenario-page branch October 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: clean scenario page
5 participants