-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: clean scenario page #9408
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9408 +/- ##
============================================
- Coverage 39.62% 39.62% -0.01%
Complexity 2270 2270
============================================
Files 1300 1300
Lines 99158 99153 -5
Branches 3282 3282
============================================
- Hits 39294 39290 -4
+ Misses 57931 57930 -1
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f1f4452
to
7a2c127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this needs to be done in this PR, but we could also swap the position between the output table and the map.
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. As there is nothing in the issue, not sure what you planned to fix here and if my comments are pertinent. But as you started to change some styles, I followed your lead :)
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_simulationresults.scss
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
c37c802
to
8b74257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
e70742a
to
a3c0778
Compare
45bd27f
to
da60413
Compare
Signed-off-by: Clara Ni <[email protected]>
da60413
to
346fabe
Compare
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
8ff3ce8
to
df97217
Compare
closes #9407
Changes
Before:
After: