Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: wrong simulation sheet spacing #9839

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

theocrsb
Copy link
Contributor

closes #9838

@theocrsb theocrsb requested a review from a team as a code owner November 25, 2024 14:08
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.79%. Comparing base (b4dd722) to head (3fda7d2).
Report is 37 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9839      +/-   ##
==========================================
- Coverage   37.79%   37.79%   -0.01%     
==========================================
  Files         994      994              
  Lines       91185    91171      -14     
  Branches     1174     1174              
==========================================
- Hits        34464    34456       -8     
+ Misses      56267    56261       -6     
  Partials      454      454              
Flag Coverage Δ
editoast 72.99% <ø> (-0.03%) ⬇️
front 20.08% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, fix respects the mockup, LGTM !

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theocrsb theocrsb added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit a2b230f Nov 26, 2024
27 checks passed
@theocrsb theocrsb deleted the tce/front/wrong-simulation-sheet-spacing branch November 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong simulation sheet spacing
4 participants