Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle ForbiddenException when atexit release #25

Merged
merged 2 commits into from
Nov 30, 2022
Merged

handle ForbiddenException when atexit release #25

merged 2 commits into from
Nov 30, 2022

Conversation

jupe
Copy link
Contributor

@jupe jupe commented Nov 30, 2022 •
edited
Loading

accept that release during atexit registered release handler can raise. Just trace it. Note that this kinda workaround for root cause, release was not done safety manner.

@jupe jupe added the enhancement New feature or request label Nov 30, 2022
@jupe jupe requested a review from lorjala November 30, 2022 08:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3581709689

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.138%
Changes Missing Coverage Covered Lines Changed/Added Lines %
stf_appium_client/StfClient.py 0 1 0.0%
Totals Coverage Status
Change from base Build 3573270077: 0.0%
Covered Lines: 355
Relevant Lines: 427
💛 - Coveralls

@jupe jupe merged commit 4c2bda8 into main Nov 30, 2022
@jupe jupe deleted the ignore_release_fail branch November 30, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorjala lorjala lorjala approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jupe @coveralls @lorjala