Fix order of checking if value is bool #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bool is subclass of int and will match against a check in `utils.is_numeric()`. This commit checks if `v` is bool before anything else, so we catch it early. ``` >>> int.__subclasses__() [<type 'bool'>] >>> isinstance(True, (int)) True >>> isinstance(True, (bool)) True ``` Previous behaviour was that jolokia tried to send `True` for booleans as a value to opentsdb, which isn't allowed, and caused `java.lang.NumberFormatException: For input string: "True"` in application logs.
jolokia has some metrics with single-tics in them as such:
`CodeHeap 'non-profiled nmethods'":
{"init":2555904,"committed":18087936,"max":121737216,"used":14709504}`
This would translate into invalid metric-names. Opentsdb accepts this
regexp in metric/tags: `[-_./a-zA-Z0-9]+`
Also changed the single-line .replace().replace() string operation into
separate lines for readability.
|
Piggy-backing another fix into this PR to fix invalid metric names generated from jolokia. No use in having separate PRs as this one hasn't been reviewed yet anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool is subclass of int and will match against a check in
utils.is_numeric(). This commit checks ifvis bool before anythingelse, so we catch it early.
Previous behaviour was that jolokia tried to send
Truefor booleans asa value to opentsdb, which isn't allowed, and caused
java.lang.NumberFormatException: For input string: "True"inapplication logs.