Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User story/1152 as a user i want to automatically download the videos from my otcamera upon connecting my usb stick #141

Conversation

randy-seng
Copy link
Member

No description provided.

@randy-seng randy-seng self-assigned this Feb 21, 2023
@randy-seng randy-seng marked this pull request as ready for review February 22, 2023 21:31
Copy link
Member

@frunika frunika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added test-data but no tests ;)

raspi-files/install_otcamera.sh Outdated Show resolved Hide resolved
OTCamera/config.py Show resolved Hide resolved
run.py Outdated Show resolved Hide resolved
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just a few comments.

usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Show resolved Hide resolved
usb_flash_drive_copy.py Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
usb_flash_drive_copy.py Outdated Show resolved Hide resolved
@randy-seng randy-seng requested a review from briemla March 20, 2023 15:56
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I only checked the code. The functionality has been tested by @randy-seng and @frunika.

@randy-seng randy-seng assigned frunika and unassigned randy-seng Mar 20, 2023
@randy-seng randy-seng requested a review from frunika March 20, 2023 17:08
usb_flash_drive_copy.py Show resolved Hide resolved
usb_flash_drive_copy.py Show resolved Hide resolved
@frunika frunika merged commit 3f68e2a into master Mar 21, 2023
@frunika frunika deleted the user-story/1152-as-a-user-i-want-to-automatically-download-the-videos-from-my-otcamera-upon-connecting-my-usb-stick branch March 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants