-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing Coverity report: part 1 #1011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all of the above are suggestions,
Also i think we should have logging defined as macros
but this is something to consider later in a major sample refactors
Last thing could be and the commit message could be To adhere with the common practices |
I see some changes in the files related to RDMA. Do we even want to implement RDMA in MTL? Will this feature ever be production ready? I think it was done as an experimental feature, and later we decided that MTL should not be responsible for RDMA. IMO, all rdma code should be removed. ( The one from Media-Transport-Library/rdma/ AND Media-Transport-Library/lib/src/dev/mt_rdma_ud* ) |
For now we decided to leave it. We can discuss to clean this up in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Address issues connected with Coverity scan