Update core-requirements.txt.j2

[denics]

add support for leds in sj201 working for devkit. Fix #95

Summary by CodeRabbit

• New Features
  • Introduced a new plugin for enhanced LED functionality in systems using the sj201 hardware, contingent on the presence of the 'tas5806' and 'attiny1614' devices.
  • Expanded installation capabilities for the OpenVoiceOS installer.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The update introduces a new dependency in the core-requirements.txt.j2 template for the OpenVoiceOS installer. It conditionally adds a Git repository for the ovos-PHAL-plugin-sj201-leds, based on the presence of the 'tas5806' or 'attiny1614' devices in the ovos_installer_i2c_devices list, enhancing the system's functionality for specific hardware.

Changes

Files	Change Summary
ansible/roles/ovos_installer/templates/virtualenv/core-requirements.txt.j2	Added git+https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds.git for conditional inclusion based on device presence.

Assessment against linked issues

Objective	Addressed	Explanation
Add LEDs manager if devkit (#95)	✅

🐰 Hopping through the code,
A new plugin's in the load!
For sj201's shining lights,
Our hardware now delights!
With LEDs bright and spirits high,
Let's celebrate, oh me, oh my! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2bb9a38 and e8f509f.

Files selected for processing (1)

• ansible/roles/ovos_installer/templates/virtualenv/core-requirements.txt.j2 (1 hunks)

Additional comments not posted (1)

ansible/roles/ovos_installer/templates/virtualenv/core-requirements.txt.j2 (1)

39-39: Verify the new dependency URL and accessibility.

The newly added dependency git+https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds.git is conditionally included based on the presence of the 'tas5806' device. Please verify the following:

• The URL is correct and points to the intended repository.
• The repository is accessible and the plugin is operational as expected.

Run the following script to verify the repository accessibility:

Verification successful

---

Dependency URL and repository accessibility verified.

The URL git+https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds.git is correct, and the repository is accessible. The dependency can be included as expected. The warning about templates does not impact the functionality.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the repository for the new dependency is accessible.

# Test: Attempt to clone the repository. Expect: Successful clone without errors.
git clone https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds.git

Length of output: 183

[goldyfruit]

@denics doesn't seem to work on a Mark II. If its working for the DevKit then you could just change the condition to make it install only when a DevKit is detected.

{% if 'attiny1614' in ovos_installer_i2c_devices %}
git+https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds.git
{% endif %}