[shell] Fix linting due to PR #147

[goldyfruit]

Summary by CodeRabbit

• Chores
  • Improved clarity in the handling of the RUN_AS_HOME variable in the installation scripts, enhancing maintainability and debugging without altering core functionality.

[coderabbitai]

Walkthrough

The changes in this pull request modify the handling of the RUN_AS_HOME variable in two scripts: installer.sh and utils/common.sh. The variable is now assigned a value without being exported initially, followed by a separate export statement. This adjustment clarifies the variable assignment process while maintaining the overall functionality of the scripts.

Changes

Files	Change Summary
installer.sh, utils/common.sh	Modified the handling of RUN_AS_HOME by separating its assignment and export into distinct steps.

Possibly related PRs

• More robust user home #147: The changes in this PR also modify the handling of the RUN_AS_HOME variable in both installer.sh and utils/common.sh, aligning with the main PR's focus on improving the clarity and correctness of variable assignment and export.

🐇 In the scripts where variables play,
A change was made to brighten the day.
Assign, then export, clear as can be,
Clarity blooms, like a flower, you see!
With hops of joy, we celebrate this feat,
For tidy code makes our work so sweet! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab513c6 and 5f40263.

Files selected for processing (2)

• installer.sh (1 hunks)
• utils/common.sh (1 hunks)

Files skipped from review due to trivial changes (1)

• utils/common.sh

Additional comments not posted (1)

installer.sh (1)

9-10: LGTM!

The change improves the clarity of the code by separating the assignment and export of the RUN_AS_HOME variable. The logic is correct, and the implementation is accurate.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.