Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/config] Disable GUI messages when headless #194

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

goldyfruit
Copy link
Member

@goldyfruit goldyfruit commented Oct 28, 2024

Closes #193

Summary by CodeRabbit

  • New Features

    • Enhanced GUI configuration options based on installation method.
    • Introduced a setting to explicitly enable the GUI when not using containers.
  • Bug Fixes

    • Adjusted existing GUI settings to ensure proper functionality across different installation methods.

@goldyfruit goldyfruit added the enhancement New feature or request label Oct 28, 2024
@goldyfruit goldyfruit added this to the Wolfenstein milestone Oct 28, 2024
@goldyfruit goldyfruit self-assigned this Oct 28, 2024
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the Jinja2 template for the Mycroft configuration file (mycroft.conf.j2). A new conditional block is introduced to manage GUI settings based on the ovos_installer_method. Specifically, when the method is not "containers", a new configuration option is added to enable the GUI explicitly. Additionally, the existing GUI configuration is adjusted to include a host path only when the method is "containers". Overall, these changes focus on enhancing the flexibility of GUI settings based on the installation method.

Changes

File Path Change Summary
ansible/roles/ovos_installer/templates/mycroft.conf.j2 Added a conditional block for GUI settings based on ovos_installer_method; introduced disable_gui: false when not using "containers" and modified gui_file_host_path handling.

Possibly related PRs

Poem

In the land of code where rabbits hop,
A GUI blooms, it won't stop!
With conditions set, the path is clear,
"Disable me not!" we cheer, oh dear!
Containers or not, we dance with glee,
Mycroft's new charm, for all to see! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@goldyfruit goldyfruit merged commit ee872f3 into main Oct 28, 2024
8 checks passed
@goldyfruit goldyfruit deleted the feat/disable_gui_messages branch October 28, 2024 00:42
@goldyfruit goldyfruit restored the feat/disable_gui_messages branch October 28, 2024 00:44
@goldyfruit goldyfruit deleted the feat/disable_gui_messages branch October 28, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gui spam
1 participant