[ansible/tuning] Fix issue when not running on a Mark II

[goldyfruit]

Fix #221

Summary by CodeRabbit

• New Features

  • Introduced dynamic detection of the boot directory for enhanced flexibility in the installation process.

• Improvements

  • Updated the NUMA enabling task to utilize the dynamically determined boot directory instead of a hardcoded path.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve the addition of two tasks in the Ansible playbook located in ansible/roles/ovos_installer/tasks/tuning/numa.yml. The first task checks for the /boot/firmware directory and registers the result, while the second task sets a fact for the boot directory based on the existence of the first directory. Additionally, an existing task is modified to utilize this new variable instead of a hardcoded path, enhancing the playbook's flexibility for configuring NUMA on Raspberry Pi devices.

Changes

File Path	Change Summary
ansible/roles/ovos_installer/tasks/tuning/numa.yml	Added tasks to check for /boot/firmware directory and set _boot_directory fact; modified existing NUMA enabling task to use _boot_directory.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure _boot_directory is defined (221)	✅
Fix installation error for Raspberry Pi 4 (221)	✅

Suggested labels

enhancement

Suggested reviewers

• JarbasAl

Poem

In a world of code, so bright and new,
A rabbit hops, with changes in view.
With paths that flex and facts that gleam,
NUMA's dance is now a dream!
So let us cheer, with joy we sing,
For every tweak, a happy spring! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e802aa6 and ee69ca6.

📒 Files selected for processing (1)

• ansible/roles/ovos_installer/tasks/tuning/numa.yml (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.