Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing vars to sound.yml #43

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Adding missing vars to sound.yml #43

merged 1 commit into from
Jan 10, 2024

Conversation

NilsGeorg
Copy link
Contributor

Related to this issue: #42

The sound.yml step Add {{ ovos_installer_user }} to pipewire group contains a condition requiring the var _distribution_version, which seems to be missing. I added this like it was done in the previous steps.

@NilsGeorg NilsGeorg requested a review from goldyfruit as a code owner January 10, 2024 15:27
@goldyfruit goldyfruit merged commit e3f9e38 into OpenVoiceOS:main Jan 10, 2024
@goldyfruit goldyfruit added the bug Something isn't working label Jan 10, 2024
@goldyfruit goldyfruit added this to the Wolfenstein milestone Jan 10, 2024
@goldyfruit
Copy link
Member

Thanks for the PR @NilsGeorg 👍

@NilsGeorg NilsGeorg deleted the fix branch January 11, 2024 17:10
@goldyfruit goldyfruit modified the milestones: Wolfenstein, Doom Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants