-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/arch_support #59
Conversation
7e00dce
to
655a902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work well for me. I tested installation into a venv with a gui and had no errors.
I few things with the installer in general
- I would like to be able to pick where my venv is
- It moves my existing
~/.config/mycroft/mycroft.conf
instead of using it, or at least asking to use it - it also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something
Overall, this works as intended, just not like I would like
Many people doesn't know what a
We discussed this point on Matrix, if the user change the
99% of the user will not have existing |
I agree with these, especially the venv. But if there are existing files, the user must know they are there, so there should at least be a prompt or verification that they are getting moved/overwritten |
IMHO this is intended, if its doing a reinstall on top of an existing one most likely something is broken or outdated, and if the user then runs this installer on top then that is what gets the user back into a working state. people who made their own service files either know what they are doing and dont want to use installer at all, or are noobs who followed some script or advice they didnt understand and now dont have a working ovos install |
Just added a backup option, if files exist and there is a change in it, then the file will be backup. |
still untested, need to verify all package names!
closes #58