-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added back button #66
Conversation
@goldyfruit please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to add BACK_BUTTON
the to other locales as well.
Just tested the PR, and I don't think this will be the best approach as I'm pretty sure users will not see the Maybe we should just replace the @mikejgray @JarbasAl what do you think? |
I agree, this is confusing because it looks like If you replace |
@goldyfruit |
@goldyfruit i have change |
Yeah looks better. 👍 |
@goldyfruit Please check I have replaced the cancel button by back button in all pages. I have to do some major changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CANCEL_BUTTON
can be removed from the locale files.
I think we should not because in future there is a chance we might need a cancel button. However, if you prefer, I will remove it. |
I would remove it since we saw that two buttons is the only "non-confusing" option. |
Good job @suvanbanerjee 👍 🎉 |
Thanks @goldyfruit for your mentorship. many more PR to go 🎉 |
added back button in first three pages. i tested it and is working i just want to know is doing it this way works ? or i am missing something.
Fixes #64