Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vocalfusion.yml to compile against currently installed kernel #88

Merged
merged 4 commits into from
May 24, 2024

Conversation

denics
Copy link
Contributor

@denics denics commented May 21, 2024

Update vocalfusion.yml to compile against currently installed and running kernel

@denics denics requested a review from goldyfruit as a code owner May 21, 2024 20:14
@goldyfruit goldyfruit added bug Something isn't working enhancement New feature or request labels May 21, 2024
@goldyfruit goldyfruit added this to the Quake milestone May 21, 2024
@goldyfruit
Copy link
Member

What if a user runs kernel 6.6.20 which is not compatible with the VocalFusionDriver?

@denics
Copy link
Contributor Author

denics commented May 21, 2024

Do we have a list of kernels that are not compatible with the VocalFusionDriver? If yes I can add a test

@goldyfruit
Copy link
Member

goldyfruit commented May 21, 2024

Do we have a list of kernels that are not compatible with the VocalFusionDriver? If yes I can add a test

< 6.6.22 🤣

@denics
Copy link
Contributor Author

denics commented May 21, 2024

je mets un test demain alors. bonne nuit :D

@denics
Copy link
Contributor Author

denics commented May 23, 2024

@goldyfruit this is a more elegant solution, I only override your variable {{ _ovos_hardware_mark2_lib_modules_path }} if we are running on kernel >= 6.6.22 . I hope you like it.

@goldyfruit goldyfruit merged commit 204101d into OpenVoiceOS:main May 24, 2024
@goldyfruit
Copy link
Member

Thanks @denics 👍 🇫🇷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants