Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GSN support (beta) #1844

Merged
merged 79 commits into from
Aug 12, 2019
Merged

Initial GSN support (beta) #1844

merged 79 commits into from
Aug 12, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Jul 26, 2019

Closes #1843

This PR includes:

  • IRelayHub, IRelayRecipient: the interfaces defined in the GSN protocol,
  • Context: a base contract with internal functions _msgSender() and _msgData(),
  • GSNContext: overrides the above with the GSN logic,
  • GSNRecipient: base functionality needed by recipients,
  • GSNBouncerBase: utilities to implement bouncers, i.e. acceptance strategies,
  • GSNBouncerERC20Charge, GSNBouncerSignature: two concrete bouncers.

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

contracts/drafts/meta-tx/GSNContext.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/GSNContext.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/GSNContext.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/Context.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/GSNContext.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/GSNContext.sol Outdated Show resolved Hide resolved
contracts/drafts/meta-tx/SigningRecipient.sol Outdated Show resolved Hide resolved
spalladino
spalladino previously approved these changes Aug 2, 2019
@frangio
Copy link
Contributor

frangio commented Aug 9, 2019

I've realized that coverage is not running with the GSN provider, but enabling it in 8a7b5be caused an issue I didn't understand.

@nventuro
Copy link
Contributor Author

LGTM!

@frangio frangio merged commit 0ec1d76 into OpenZeppelin:master Aug 12, 2019
@nventuro nventuro deleted the gsn-beta branch August 12, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GSN Recipient base contracts and strategies to Contracts
3 participants