-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a canceller role to the TimelockController #3165
Add a canceller role to the TimelockController #3165
Conversation
78c09a8
to
91b1f1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Cancellor" is a typo, it should be "canceller".
In the changelog, we should explain that if an instance is upgraded the role needs to be set up (admin and members).
AFAIK, both cancellor and canceller are valid. One is American english, the other is British english. |
No, you may be confusing it with "chancellor"? "Cancellor" doesn't seem to exist at all. |
I did put "Cancellor" in my translator, and got what I expected. I'm going to change it just to be safe. (and no, I'm not confusing chancellor Palpatine with cancellor Palpatine :P) |
Co-authored-by: Francisco Giordano <[email protected]>
…le' into fix/TimelockController/CancellorRole
I would expect the tests to set up different proposer and canceller accounts, so we can separately test them. Note: it also makes sense to test that in the default constructor the proposer array is assigned canceller roles. |
This is good but needs a changelog entry. |
Fixes #2980
PR Checklist