-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Strings.equal #3774
Add Strings.equal #3774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'd like to explorer further if there's a cheaper way of doing this since keccak is an expensive operation.
I don't think it's worth it at the moment but mentioning for the record.
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Hi! I'd like to propose the addition of the new method
equal
for Strings, which would make things more elegant and make the code less repetitive. Also, it should be really useful for testing purposes with Foundry.I'm referring to this (old) issue: #1795 (comment)
PR Checklist