Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isValidERC1271SignatureNow to SignatureChecker library #3932

Merged

Conversation

YamenMerhi
Copy link
Contributor

@YamenMerhi YamenMerhi commented Jan 5, 2023

Fixes #3912

  • Tests
  • Documentation
  • Changelog entry

Amxx
Amxx previously approved these changes Jan 12, 2023
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Waiting on @frangio 's review

@Amxx Amxx requested a review from frangio January 23, 2023 09:49
@Amxx Amxx added this to the 4.9 milestone Jan 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: ecc103a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Amxx
Amxx previously approved these changes Jan 23, 2023
frangio
frangio previously approved these changes Feb 21, 2023
@frangio frangio enabled auto-merge (squash) February 21, 2023 14:55
@frangio frangio merged commit 1e245aa into OpenZeppelin:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add strict ERC1271 Signature Checking in SignatureChecker library
3 participants