Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling error in CHANGELOG.md #4232

Merged

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented May 10, 2023

I noticed that #4231 (that targets release-v4.9) is failing codespell.

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

⚠️ No Changeset found

Latest commit: a235fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested a review from frangio May 10, 2023 16:21
@ernestognw
Copy link
Member

I wonder if codespell is checking changesets. This should've been flagged previously.
I don't find any configuration for codespell, any idea why is not checking changesets?

@Amxx
Copy link
Collaborator Author

Amxx commented May 10, 2023

from .github/workflows/checks.yml:

  codespell:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Run CodeSpell
        uses: codespell-project/[email protected]
        with:
          check_filenames: true
          skip: package-lock.json,*.pdf

(maybe codespell doesn't check folders that start with a dot like .changeset ???)

@frangio
Copy link
Contributor

frangio commented May 10, 2023

I believe this needs to be fixed in the changeset itself too.

@frangio
Copy link
Contributor

frangio commented May 10, 2023

https://github.com/codespell-project/actions-codespell#parameter-check_hidden

Parameter: check_hidden

If set, check hidden files (those starting with ".") for spelling mistakes as well.

This parameter is optional; by default codespell will not check hidden files.

#4236

@frangio frangio merged commit 46d5a87 into OpenZeppelin:release-v4.9 May 10, 2023
@Amxx Amxx deleted the spelling/release-v4.9/changelog branch May 10, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants