Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.adoc #4336

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Update index.adoc #4336

merged 2 commits into from
Jun 13, 2023

Conversation

zackrw
Copy link
Contributor

@zackrw zackrw commented Jun 10, 2023

Add link to [OpenZeppelin Contracts Security Center]

@zackrw
Update index.adoc
8e84988 
Add link to OpenZeppelin Contracts Security Center
@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1717a2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Jun 12, 2023 •
edited
Loading

IMO we should also add that to the readme as well (done in another PR: #4335)

Amxx
Amxx previously approved these changes Jun 12, 2023
View reviewed changes
ernestognw
ernestognw previously approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block for this, but a small nit to check

docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
@zackrw zackrw dismissed stale reviews from ernestognw and Amxx via 1717a2a June 13, 2023 20:24
ernestognw
ernestognw approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zackrw!

@frangio frangio merged commit d6c7cee into OpenZeppelin:master Jun 13, 2023
frangio pushed a commit that referenced this pull request Jun 13, 2023
@zackrw @frangio
Update index.adoc (#4336)
ded8c9e 
Co-authored-by: Ernesto García <[email protected]>
(cherry picked from commit d6c7cee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackrw @Amxx @ernestognw @frangio