Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component - OdsTextToggleButtonsRow #530

Closed
paulinea opened this issue May 10, 2023 · 3 comments · Fixed by #559 or #680
Closed

Component - OdsTextToggleButtonsRow #530

paulinea opened this issue May 10, 2023 · 3 comments · Fixed by #559 or #680
Labels
👂 accessibility 🐞 bug Something isn't working ⚛️ Component 📱 demo app 👌 OK Design 👌 OK PO

Comments

@paulinea
Copy link
Member

Add a text toggle buttons row component :
TextToggleRow
@paulinea paulinea added 🔍 triage A new issue that needs to be treated 📱 demo app ⚛️ Component labels May 10, 2023
@B3nz01d B3nz01d removed the 🔍 triage A new issue that needs to be treated label Jun 14, 2023
@dolinetouko dolinetouko self-assigned this Jun 22, 2023
dolinetouko added a commit that referenced this issue Jun 22, 2023
@dolinetouko
[#530] Add component ButtonsTextToggleGroup
a18e064
dolinetouko added a commit that referenced this issue Jun 28, 2023
@dolinetouko
[#530] Add OdsTextToggleButton
22baa0c
@dolinetouko dolinetouko linked a pull request Jun 28, 2023 that will close this issue
530 - Component Odstexttogglebuttonsrow #559
Merged
dolinetouko added a commit that referenced this issue Jun 28, 2023
@dolinetouko
[#530] Add OdsTextToggleButton
42002d8
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review : remove max_value
654a77c
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review : Add OdsToggleButtonsRowCommon
7c2051e
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review : change string value
86b400f
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review: remove filter in the recipe list
e85fdc4
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review: update code implementation
2b7088c
dolinetouko added a commit that referenced this issue Aug 2, 2023
@dolinetouko
[#530] Review : update OdsTextToggleButtonsRow
f08130b
florentmaitre added a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review: Update changelog.md
007e2b2 
Co-authored-by: Florent Maitre <[email protected]>
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review : remove max_value
9ba9cd5
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review : Add OdsToggleButtonsRowsCommon
74637c2
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review : change string value
c0f02f8
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review: remove filter in the recipe list
f1e11a3
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review: update code implementation
98f0fce
florentmaitre pushed a commit that referenced this issue Aug 8, 2023
@dolinetouko @florentmaitre
[#530] Review : update OdsTextToggleButtonsRow
3cdc23c
florentmaitre added a commit that referenced this issue Aug 8, 2023
@florentmaitre
[#530] Review: OdsTextButton method with maxLines and overflow parame…
9fb6442 
…ters is now internal
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned dolinetouko Aug 11, 2023
@B3nz01d B3nz01d removed their assignment Aug 24, 2023
@afrahB afrahB added 🐞 bug Something isn't working 👂 accessibility and removed 👂 accessibility 🐞 bug Something isn't working labels Sep 28, 2023
@afrahB
Copy link

afrahB commented Sep 28, 2023

in light mode the contrast for the selected element is not sufficient @mccart77
it's ok for the dark mode

@afrahB afrahB added 🐞 bug Something isn't working 👂 accessibility labels Oct 23, 2023
@mccart77
Copy link
Collaborator

Contrast colour ratio for the selected tab does not meet the accessibility criteria, as Highlighted by Accessibility team.

The issue has been discussed in the Mobile Specification Meeting - the following was decided:

For light mode
For the selected text tab, the text colour will be updated to be black (#000000) for all interactive states. The selected background colour will stay as it is (orange).

For dark mode
For the selected text tab, the text colour will be updated to be white (#FFFFFF) for all interactive states. The selected background colour will stay as it is (orange).

@mccart77 mccart77 reopened this Oct 23, 2023
@paulinea paulinea linked a pull request Oct 23, 2023 that will close this issue
Change OdsTextToggleButtonsRow selected button text color for accessibility reason #680
Merged
@paulinea
Copy link
Member Author

Contrast colour ratio for the selected tab does not meet the accessibility criteria, as Highlighted by Accessibility team.

The issue has been discussed in the Mobile Specification Meeting - the following was decided:

For light mode For the selected text tab, the text colour will be updated to be black (#000000) for all interactive states. The selected background colour will stay as it is (orange).

For dark mode For the selected text tab, the text colour will be updated to be white (#FFFFFF) for all interactive states. The selected background colour will stay as it is (orange).

@afrahB @mccart77 This is ok on our side, you will be able to test it in the today release.

@mccart77 mccart77 removed their assignment Oct 25, 2023
@afrahB afrahB assigned mccart77 and unassigned afrahB Oct 27, 2023
@mccart77 mccart77 removed their assignment Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👂 accessibility 🐞 bug Something isn't working ⚛️ Component 📱 demo app 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
5 participants
@paulinea @dolinetouko @B3nz01d @mccart77 @afrahB