Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Placeholder image #531

Closed
B3nz01d opened this issue May 11, 2023 · 3 comments · Fixed by #769
Closed

Update the Placeholder image #531

B3nz01d opened this issue May 11, 2023 · 3 comments · Fixed by #769
Assignees
Labels
🧩 enhancement New feature or request 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented May 11, 2023

Requirement

As a User of the library
I Want to lad images
So That there is:

  • a placeholder image when loading the image
  • a placehodler error image when there is an error in loading the image
  • a placeholder image adapted for ligh and dark mode

General description

New images have been provided for placeholder images using the solaris icon. These new images need to be used to replace the existing ones.

@B3nz01d B3nz01d added the 🧩 enhancement New feature or request label May 11, 2023
@florentmaitre
Copy link
Member

We already have placeholder.png, placeholder_error.png and placeholder_dark.png image resources in the demo app and we can make them available in the library.

However it would be better to have vector images.

@florentmaitre florentmaitre self-assigned this Aug 7, 2023
@paulinea
Copy link
Member

paulinea commented Aug 7, 2023

@B3nz01d @ChristineKuster Could you provide us 4 vector images for placeholders: placeholder.svg, placeholder_dark.svg, placeholder_error.svg, placeholder_error_dark.svg?

@ChristineKuster
Copy link

@paulinea Hi Pauline, I don't know what is it about ! We can talk about during the Android meeting of wednesday

florentmaitre added a commit that referenced this issue Jan 4, 2024
…ot change when switching between light and dark mode
@florentmaitre florentmaitre linked a pull request Jan 4, 2024 that will close this issue
florentmaitre added a commit that referenced this issue Jan 17, 2024
…ot change when switching between light and dark mode
florentmaitre added a commit that referenced this issue Jan 18, 2024
…ot change when switching between light and dark mode
@paulinea paulinea assigned B3nz01d and unassigned florentmaitre Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 enhancement New feature or request 👌 OK PO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants