OCC-237: Checkout page throws exception because of non awaited async …

…method (#432)

* Waiting for numeric order result

* Refactoring to comply with VSTHRD003

#VSTHRD003: Avoid awaiting or returning a Task representing work that was not started within your context as that can lead to deadlocks.

src/Modules/OrchardCore.Commerce.ContentFields/Services/FieldsOnlyDisplayManager.cs

@@ -39,14 +39,21 @@ public async Task<IEnumerable<string>> GetFieldShapeTypesAsync(
         string displayType = CommonContentDisplayTypes.Detail)
     {
         var typeDefinition = await _contentDefinitionManager.GetTypeDefinitionAsync(contentItem.ContentType);
+
+        var partsOrders = new Dictionary<string, int>();
+        foreach (var part in typeDefinition.Parts)
+        {
+            partsOrders.Add(part.Name, await GetNumericOrderAsync(part));
+        }
+
         return typeDefinition
             .Parts
             .SelectMany(part =>
                 part.PartDefinition.Fields.Select(field => new
                 {
                     PartName = part.Name,
                     FieldName = field.Name,
-                    PartOrder = GetNumericOrderAsync(part),
+                    PartOrder = partsOrders[part.Name],
                     FieldOrder = GetNumericOrder(field),
                 }))
             .OrderBy(item => item.PartOrder)