Skip to content

Commit

Permalink
Fixing small UI issues (#2961)
Browse files Browse the repository at this point in the history
Adding styles to prevent menu item title text to expand if title is too long.
Fixed GraphiQL and Media UI after changing the collapsed admin menu size.
Aligning more properly the collapsible chevron icon vertically.
  • Loading branch information
Skrypt authored and sebastienros committed Dec 31, 2018
1 parent 9c507fb commit 4477749
Show file tree
Hide file tree
Showing 10 changed files with 43 additions and 29 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#graphiql {
position: absolute;
top: 59px;
top: 49px;
bottom: 0;
right: 0;
left: 260px;
Expand All @@ -13,7 +13,7 @@


.left-sidebar-compact #graphiql {
left: 60px;
left: 48px;
transition: left 0.2s ease-in-out, width 0.2s ease-in-out;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#graphiql {
position: absolute;
top: 59px;
top: 49px;
bottom: 0;
right: 0;
left: 260px;
Expand All @@ -14,7 +14,7 @@
overflow-x: unset; }

.left-sidebar-compact #graphiql {
left: 60px;
left: 48px;
transition: left 0.2s ease-in-out, width 0.2s ease-in-out; }

.graphiql-container .docExplorerShow {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,5 @@
}

.left-sidebar-compact #mediaApp {
position: absolute;
top: 128px;
bottom: 0;
right: 0;
left: 60px;
transition: left 0.2s ease-in-out, width 0.2s ease-in-out;
left: 48px;
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
@import "drop-zone.scss";
@import "media-field.scss";
@import "modal-view.scss";
@import "utils.scss";
@import "utils.scss";
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@
height: 100%; }

.left-sidebar-compact #mediaApp {
position: absolute;
top: 128px;
bottom: 0;
right: 0;
left: 60px;
transition: left 0.2s ease-in-out, width 0.2s ease-in-out; }
left: 48px; }

.upload {
background-color: rgba(0, 0, 0, 0.05);
Expand Down

Large diffs are not rendered by default.

18 changes: 15 additions & 3 deletions src/OrchardCore.Themes/TheAdmin/Assets/scss/TheAdmin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ body:not(.left-sidebar-compact) {

.chevron {
position: absolute;
top: 33%;
top: 38%;
left: 100%;
margin-left: -25px;
}
Expand Down Expand Up @@ -273,6 +273,10 @@ body:not(.left-sidebar-compact) {
> span.title {
flex-grow: 1;
font-size: 14px;
width: calc(100% - 48px - 45px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
}

Expand Down Expand Up @@ -479,7 +483,7 @@ body:not(.left-sidebar-compact) {

.chevron {
position: absolute;
top: 33%;
top: 38%;
left: 100%;
margin-left: -25px;
}
Expand Down Expand Up @@ -561,6 +565,10 @@ body:not(.left-sidebar-compact) {
> span.title {
flex-grow: 1;
font-size: 14px;
width: calc(100% - 48px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
}

Expand Down Expand Up @@ -664,7 +672,7 @@ body:not(.left-sidebar-compact) {
display: flex;

.title {
padding-left: 20px;
padding: 0 20px;

&:hover {
background-color: $gray-100 !important;
Expand All @@ -688,6 +696,10 @@ body:not(.left-sidebar-compact) {
flex-grow: 1;
font-size: 14px;
font-weight: bold;
width: calc(100% - 48px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}

> span.title:after {
Expand Down
24 changes: 18 additions & 6 deletions src/OrchardCore.Themes/TheAdmin/wwwroot/Styles/TheAdmin.css
Original file line number Diff line number Diff line change
Expand Up @@ -7084,7 +7084,7 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
display: block; }
body:not(.left-sidebar-compact) #ta-left-sidebar .chevron {
position: absolute;
top: 33%;
top: 38%;
left: 100%;
margin-left: -25px; }
body:not(.left-sidebar-compact) #ta-left-sidebar label, body:not(.left-sidebar-compact) #ta-left-sidebar a {
Expand Down Expand Up @@ -7145,7 +7145,11 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
width: 35px; }
body:not(.left-sidebar-compact) #ta-left-sidebar #left-nav > ul.menu-admin .item-label > span.title {
flex-grow: 1;
font-size: 14px; }
font-size: 14px;
width: calc(100% - 48px - 45px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis; }
body:not(.left-sidebar-compact) #ta-left-sidebar #left-nav > ul.menu-admin > li > .item-label > .collapse-icon {
color: rgba(255, 0, 0, 0);
display: flex;
Expand Down Expand Up @@ -7277,7 +7281,7 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
display: block; }
.left-sidebar-compact #ta-left-sidebar .chevron {
position: absolute;
top: 33%;
top: 38%;
left: 100%;
margin-left: -25px; }
.left-sidebar-compact #ta-left-sidebar label, .left-sidebar-compact #ta-left-sidebar a {
Expand Down Expand Up @@ -7332,7 +7336,11 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
width: 37px; }
.left-sidebar-compact #ta-left-sidebar #left-nav > ul .item-label > span.title {
flex-grow: 1;
font-size: 14px; }
font-size: 14px;
width: calc(100% - 48px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis; }
.left-sidebar-compact #ta-left-sidebar #left-nav > ul > li > .item-label > .collapse-icon {
color: rgba(255, 0, 0, 0);
display: flex;
Expand Down Expand Up @@ -7399,7 +7407,7 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
padding-left: 0px !important;
display: flex; }
.left-sidebar-compact #ta-left-sidebar #left-nav > ul > li > .item-label .title {
padding-left: 20px; }
padding: 0 20px; }
.left-sidebar-compact #ta-left-sidebar #left-nav > ul > li > .item-label .title:hover {
background-color: #f8f9fa !important;
color: #495057; }
Expand All @@ -7414,7 +7422,11 @@ body:not(.left-sidebar-compact) #ta-left-sidebar {
.left-sidebar-compact #ta-left-sidebar #left-nav > ul > li > .item-label > span.title {
flex-grow: 1;
font-size: 14px;
font-weight: bold; }
font-weight: bold;
width: calc(100% - 48px);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis; }
.left-sidebar-compact #ta-left-sidebar #left-nav > ul > li > .item-label > span.title:after {
content: "";
height: 1px;
Expand Down

Large diffs are not rendered by default.

0 comments on commit 4477749

Please sign in to comment.