Skip to content

Commit

Permalink
Fix content preview editor resource dependency (#14642)
Browse files Browse the repository at this point in the history
  • Loading branch information
giannik authored Nov 6, 2023
1 parent ca4e786 commit 8d2aa01
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ static ResourceManagementOptionsConfiguration()

_manifest
.DefineScript("contentpreview-edit")
.SetDependencies("admin")
.SetUrl("~/OrchardCore.ContentPreview/Scripts/contentpreview.edit.min.js", "~/OrchardCore.ContentPreview/Scripts/contentpreview.edit.js")
.SetVersion("1.0.0");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
}

<script asp-name="js-cookie" at="Foot"></script>
<script asp-name="jQuery" at="Foot"></script>

<iframe id="iframe" title="iframe" style="position:fixed; top:0px; left:0px; bottom:0px; right:0px; width:100%; height:100%; border:none; margin:0; padding:0; overflow:hidden; z-index:999990;">
Your browser doesn't support iframes
Expand All @@ -24,7 +25,7 @@

<resources type="Footer" />

<script>
<script at="Foot" depends-on="jQuery">

This comment has been minimized.

Copy link
@giannik

giannik Nov 6, 2023

Author Contributor

@MikeAlhayek these attributes dont apply because the the resourses have been already been rendered

This comment has been minimized.

Copy link
@giannik

giannik Nov 6, 2023

Author Contributor

@MikeAlhayek this addition breaks the preview.please remove

var renderPreviewUrl = $(document.getElementById('renderPreviewUrl')).data('value');
var iframe = document.getElementById('iframe');
var previewEventTimer = null;
Expand Down

0 comments on commit 8d2aa01

Please sign in to comment.