Fixing ObjectDisposedException when using database shell settings

OrchardCMS · Nov 25, 2024 · d6f7bfc · d6f7bfc
1 parent 95f1849
commit d6f7bfc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/...ardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs b/...ardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellConfigurationSources.cs
@@ -74,9 +74,7 @@ public async Task AddSourcesAsync(string tenant, IConfigurationBuilder builder)
         if (configuration is not null)
         {
             var configurationString = configuration.ToJsonString(JOptions.Default);
-            using var stream = new MemoryStream(Encoding.UTF8.GetBytes(configurationString));
-
-            builder.AddTenantJsonStream(stream);
+            builder.AddTenantJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(configurationString)));
         }
     }
 

diff --git a/...OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs b/...OrchardCore.Infrastructure/Shells.Database/Configuration/DatabaseShellsSettingsSources.cs
@@ -42,9 +42,7 @@ public async Task AddSourcesAsync(IConfigurationBuilder builder)
         if (document.ShellsSettings is not null)
         {
             var shellsSettingsString = document.ShellsSettings.ToJsonString(JOptions.Default);
-            using var stream = new MemoryStream(Encoding.UTF8.GetBytes(shellsSettingsString));
-
-            builder.AddTenantJsonStream(stream);
+            builder.AddTenantJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(shellsSettingsString)));
         }
     }
 
@@ -55,9 +53,7 @@ public async Task AddSourcesAsync(string tenant, IConfigurationBuilder builder)
         {
             var shellSettings = new JsonObject { [tenant] = document.ShellsSettings[tenant] };
             var shellSettingsString = shellSettings.ToJsonString(JOptions.Default);
-            using var stream = new MemoryStream(Encoding.UTF8.GetBytes(shellSettingsString));
-
-            builder.AddTenantJsonStream(stream);
+            builder.AddTenantJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(shellSettingsString)));
         }
     }