Skip to content

Commit

Permalink
Fix incorrect description (#17062)
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] authored Nov 25, 2024
1 parent b2a5b54 commit e4b3fbc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ public async Task<IActionResult> ExternalLoginCallback(string returnUrl = null,

// The user doesn't exist and no information required, we can create the account locally
// instead of redirecting to the ExternalLogin.
var noInformationRequired = externalLoginViewModel.NoPassword
&& externalLoginViewModel.NoEmail
&& externalLoginViewModel.NoUsername;
var noInformationRequired = settings.NoPassword &&
settings.NoEmail &&
settings.NoUsername;

if (noInformationRequired)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ public class RegistrationSettings

public bool UseSiteTheme { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalAuthenticationSettings.NoPassword")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalRegistrationSettings.NoPassword")]
public bool NoPasswordForExternalUsers { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalAuthenticationSettings.NoUsername")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalRegistrationSettings.NoUsername")]
public bool NoUsernameForExternalUsers { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalAuthenticationSettings.NoEmail")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalRegistrationSettings.NoEmail")]
public bool NoEmailForExternalUsers { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalAuthenticationSettings.UseScriptToGenerateUsername")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalRegistrationSettings.UseScriptToGenerateUsername")]
public bool UseScriptToGenerateUsername { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalAuthenticationSettings.GenerateUsernameScript")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalRegistrationSettings.GenerateUsernameScript")]
public string GenerateUsernameScript { get; set; }
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ public class LoginSettings
{
public bool UseSiteTheme { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalUserLoginSettings.NoPassword")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalLoginSettings.UseExternalProviderIfOnlyOneDefined")]
public bool UseExternalProviderIfOnlyOneDefined { get; set; }

public bool DisableLocalLogin { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalUserRoleLoginSettings.SyncRolesScript")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalLoginSettings.UseScriptToSyncProperties")]
public bool UseScriptToSyncRoles { get; set; }

[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalUserRoleLoginSettings.SyncRolesScript")]
[Obsolete("This property is no longer used and will be removed in the next major release. Instead use ExternalLoginSettings.SyncPropertiesScript")]
public string SyncRolesScript { get; set; }

public bool AllowChangingUsername { get; set; }
Expand Down

0 comments on commit e4b3fbc

Please sign in to comment.