Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In templates the Preview button always renders the home page #10055

Open
giannik opened this issue Aug 7, 2021 · 4 comments
Open

In templates the Preview button always renders the home page #10055

giannik opened this issue Aug 7, 2021 · 4 comments
Milestone

Comments

@giannik
Copy link
Contributor

giannik commented Aug 7, 2021

In the templates from the admin there is preview button but this always renders the home page.
Is this deliberate or am i missing something ?

image

@giannik giannik changed the title In templates the Preview button always renders thye home page In templates the Preview button always renders the home page Aug 7, 2021
@Skrypt
Copy link
Contributor

Skrypt commented Aug 10, 2021

That's because these templates are not assigned to any specific content item of any content type. Maybe it could create a temporary content item of some content type to display it. Else, it will require some thinking.

@sebastienros
Copy link
Member

I believe that if you then navigate the preview page you can reach a page that contains the template you are editing. Otherwise there is no way to know which preview to open. You might even want to test the template on different pages.

@sebastienros sebastienros added this to the backlog milestone Sep 9, 2021
@Piedone
Copy link
Member

Piedone commented May 21, 2024

Is this still applicable after #16072?

@hishamco
Copy link
Member

I noticed that too, the #16072 is fixing the preview issue, but the default implementation always open the home page, I was thinking when I was working on the PR to come up with an idea to open the related content, this might be tricky because

  • Template naming is by convension
  • Propbably there's no content items for such content type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants