Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Preview doesn't show anything #16072

Closed
hishamco opened this issue May 16, 2024 · 10 comments · Fixed by #16096
Closed

Template Preview doesn't show anything #16072

hishamco opened this issue May 16, 2024 · 10 comments · Fixed by #16096
Assignees
Labels
Milestone

Comments

@hishamco
Copy link
Member

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Design'
  2. Click on 'Templates'
  3. Create a new template
  4. Click on 'Preview'

Expected behavior

Shows a template for a certain content type

Copy link
Contributor

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. A core team member will review your issue and get back to you.

@hishamco
Copy link
Member Author

hishamco commented May 16, 2024

@Piedone this is not my first issue, seems the bot drank something, so it isn't aware of the old issues :)

@Piedone
Copy link
Member

Piedone commented May 16, 2024

Sorry, I have no idea, must be a fluke, since it worked until now precisely.

More to the point: please provide more info, because it doesn't reproduce for me with the latest main.

@hishamco
Copy link
Member Author

I just noticed this while I was working on OrchardCore.Website, @agriffard could you please confirm or it's due a permission restriction

@Piedone
Copy link
Member

Piedone commented May 16, 2024

Oh wait, I misunderstood, and tried content preview. Template preview indeed is broken.

Looking at the Template module's PreviewController, I don't really see how it was ever supposed to work.

@hishamco
Copy link
Member Author

Oh wait, I misunderstood, and tried content preview. Template preview indeed is broken.

I expect that :)

Looking at the Template module's PreviewController, I don't really see how it was ever supposed to work.

I will have a look. I'm not sure how the template is rendering without data?!! Maybe to see what it looks like

@MikeAlhayek
Copy link
Member

this is not my first issue, seems the bot drank something, so it isn't aware of the old issues :)

This is just a wake up call so you can submit more issues :)

@hishamco hishamco self-assigned this May 18, 2024
@hishamco
Copy link
Member Author

This was the first issue I just found, seems no one click that button from 3 years :)

@MikeAlhayek
Copy link
Member

@hishamco I think this issue was introduced after the major BS 5.3 upgrade

@hishamco
Copy link
Member Author

I don't know but the script reference is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants