Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus signs in Media file or folder name break Media Library links and previews #11673

Open
IsQiao opened this issue May 10, 2022 · 5 comments
Open
Milestone

Comments

@IsQiao
Copy link

IsQiao commented May 10, 2022

Describe the bug

if i upload a file named aaa+++.jpg to azure storage. it will lost in preview page.

To Reproduce

Steps to reproduce the behavior:

  1. Upload a file named aaa+++.png in media library page.
  2. File name become a aaa .png in preview page. but the real filename is aaa+++.png
  3. So the file not found.

Expected behavior

the filename is aaa+++.png in preview page

Screenshots

image
image

@sebastienros sebastienros added this to the 1.x milestone May 12, 2022
@Piedone Piedone changed the title Bug: Media file not found when use azure blob storage Special characters in file name break Azure Blob Storage May 27, 2024
@Piedone Piedone changed the title Special characters in file name break Azure Blob Storage Plus signs in file name break Azure Blob Storage May 27, 2024
@Piedone Piedone changed the title Plus signs in file name break Azure Blob Storage Plus signs in Media file or folder name break Media Library links and previews May 27, 2024
@Piedone
Copy link
Member

Piedone commented May 27, 2024

I just checked, and this is a generic Media issue, not just specific to Azure Blob Storage. Furthermore, as the duplicate #16163 issue explains, this is also a problem with the plus sign in the folder names too. So, this needs to be fixed on a higher level, not just for Blob Storage, and for folder names too.

See that other issue for different repro steps.

@gvkries
Copy link
Contributor

gvkries commented May 28, 2024

I thought that maybe #16135 fixes issue #16163 as well, but I couldn't repro it from the main branch with local files (on Windows). So not sure if it still is an issue or has been fixed. Can someone else check again? Thanks.

@Piedone
Copy link
Member

Piedone commented May 28, 2024

Yes, still get the same with the current main:

image

@gvkries
Copy link
Contributor

gvkries commented May 28, 2024

That's because of IIS, isn't it? I used Kestrel...

@Piedone
Copy link
Member

Piedone commented May 28, 2024

Might be that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants