fix: azure blob file not found #11674
Conversation
|
The fix is questionnable. Needs investigation. |
| @@ -145,7 +145,7 @@ await foreach (var blob in page) | |||
| } | |||
| else | |||
| { | |||
| var itemName = Path.GetFileName(WebUtility.UrlDecode(blob.Blob.Name)).Trim('/'); | |||
| var itemName = Path.GetFileName(blob.Blob.Name).Trim('/'); | |||
There was a problem hiding this comment.
The decode code is old from the previous blob library from Microsoft.
It maybe that it is no longer delivered by the azure library encoded, so a decode doesn't do anything useful.
There was a problem hiding this comment.
the decode can damage file path. aaa+++.jpg -> aaa .jpg
remove decode can resolve it if use Kestrel Server.
but need to set allowDoubleEscaping="true" in web.config if use IIS Server.
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
There was a problem hiding this comment.
Please check the decode in GetDirectoryContentFlatAsync() too.
While this indeed fixes the linked bug, I'm not sure if it'll break anything else. Can you upload a file to Blob Storage with a name that has all kinds of characters that should be encoded for a URL, and it'll keep them in their original form?
There was a problem hiding this comment.
ok, i will to test all kinds of chars for this case and resolve the PR conflicts. please wait.
|
Not to be a bother, but any news here, @IsQiao? |
sync parent repo
|
Sorry, I found new bugs regarding this fix and I will fix them. |
|
Great, thanks! When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done. |
ok, i will click the button after fix the bug. thanks |
|
This needs to be fixed not just for Blob Storage, see #11673 (comment). |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
Fixes #11673