Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UpdateAtomic Delegates distinct #12544

Closed
jtkech opened this issue Oct 2, 2022 · 0 comments · Fixed by #12545
Closed

Make UpdateAtomic Delegates distinct #12544

jtkech opened this issue Oct 2, 2022 · 0 comments · Fixed by #12545
Labels
Milestone

Comments

@jtkech
Copy link
Member

jtkech commented Oct 2, 2022

Maybe I'm alone to use IVolatileDocumentManager.UpdateAtomicAsync(), see #10673 where we fixed a first problem but the 2nd concern is still there, otherwise it works well.

So, when enlisting multiple update delegates (not allowed with the regular UpdateAsync()) in bulk actions, we can still enlist multiple times the same delegate, we wanted to make the results of the delegate invocation list distincts, but they are wrapped objects for which the equality operator overload is not sufficient.

I fixed it locally by checking the Target directly on the the delegates passed as parameters, this in place of checking the delegates retrieved from the invocation list of the combined delegate.

I will do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants