Two alerts displayed in admin settings to reload the current tenant

[agriffard]

The /Admin/Settings/email page displays 2 identical warning alerts:
The current tenant will be reloaded when the settings are saved.

[agriffard]

/Admin/Settings/localization too.

[ns8482e]

Maybe added twice by notifier service?

[agriffard]

/Admin/Settings/SecurityHeader

[jtkech]

The easiest way is to remove the alert from Settings-General.Wrapper.cshtml where it has been added, and re-add the alert in Settings.Edit.cshtml. So that we don't have to check where we need or not to remove the alert in all other dedicated settings shape views.

[MikeAlhayek]

@jtkech the notification is needed in the wrapper. But we should only apply the wrapper when the group is general. I'll submit a PR

[jtkech]

Okay so maybe the right fix is in the driver

        if (context.GroupId.Equals(GroupId, StringComparison.OrdinalIgnoreCase))
        {
            context.Shape.Metadata.Wrappers.Add("Settings_Wrapper__General");
        }

[jtkech]

Or just

        if (!context.GroupId.Equals(GroupId, StringComparison.OrdinalIgnoreCase))
        {
            return Task.FromResult<IDisplayResult>(null);
        }

[MikeAlhayek]

@jtkech yes that is what I suggested in the PR #14315

[jtkech]

Okay then