Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless NotifyUserTask #14748

Closed
MikeAlhayek opened this issue Nov 23, 2023 · 1 comment · Fixed by #16073
Closed

Remove useless NotifyUserTask #14748

MikeAlhayek opened this issue Nov 23, 2023 · 1 comment · Fixed by #16073
Milestone
2.0

Comments

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Nov 23, 2023 •
edited
Loading

I think the NotifyUserTask is useless and should be removed.

Unless we salvage it by adding a required username input so the user can specify a username to notify.
@sebastienros sebastienros added this to the 1.x milestone Dec 7, 2023
@sebastienros
Copy link
Member

Didn't you provide the PR for that?

MikeAlhayek added a commit that referenced this issue May 16, 2024
@MikeAlhayek
Add a way to specify username to notify
ba64712 
Fix #14748
@MikeAlhayek MikeAlhayek mentioned this issue May 16, 2024
Merged
@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add a way to specify username to send notifications to OrchardCMS/OrchardCore
2 participants
@sebastienros @MikeAlhayek