Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont ping Elasticsearch during the app bootstraping process #14893

Closed
MikeAlhayek opened this issue Dec 13, 2023 · 0 comments · Fixed by #14875
Closed

Dont ping Elasticsearch during the app bootstraping process #14893

MikeAlhayek opened this issue Dec 13, 2023 · 0 comments · Fixed by #14875
Labels
bug 🐛
Milestone
1.8

Comments

@MikeAlhayek
Copy link
Member

Currently, we ping the Elasticsearch client during building the tenant

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Search.Elasticsearch/Startup.cs#L160

I don't think it is a good idea to lock the current thread while the tenant is being created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Ping Elasticsearch async OrchardCMS/OrchardCore
2 participants
@sebastienros @MikeAlhayek