Ping Elasticsearch async #14875
Merged
Ping Elasticsearch async #14875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested review from
jtkech
and removed request for
agriffard and
kevinchalet
Skrypt
reviewed
Jan 3, 2024
| } | ||
|
|
||
| [RequireFeatures("OrchardCore.Deployment")] | ||
| public class DeploymentStartup : StartupBase | ||
| { | ||
| public override void ConfigureServices(IServiceCollection services) | ||
| { | ||
| if (services.Any(d => d.GetImplementationType() == typeof(ElasticsearchService))) |
There was a problem hiding this comment.
Ok that's the part that @sebastienros doesn't like. Then, I'm guessing we are removing this everywhere else too?
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14893
In the past we did not call
services.AddElasticServices();if thePing()request throw an exception. Note, previously it could fail even without exception. The response.IsValid property was not taken into consideration. So the response could succeed but returns like 404 and we still proceed.Updated
As per recommendation from @sebastienros , we don't need to ping the server at all. Instead, we should add a Elasticsearch to our health check so it is checked on regular bases.