Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheTheme has Navbar UserMenu malformed HTML #15158

Closed
ethankershaw opened this issue Jan 24, 2024 · 1 comment · Fixed by #15231
Closed

TheTheme has Navbar UserMenu malformed HTML #15158

ethankershaw opened this issue Jan 24, 2024 · 1 comment · Fixed by #15231
Labels
Milestone

Comments

@ethankershaw
Copy link

ethankershaw commented Jan 24, 2024

Describe the bug

TheTheme's Navbar seems to have the light/dark theme toggle and a user menu by default. The HTML for the user menu portion is malformed as an li inside of an li.

                    <li class="nav-item">

                    <li class="nav-item dropdown text-end">
                        <a href="#" class="nav-link dropdown-toggle" data-bs-toggle="dropdown">
                            <i class="fa-solid fa-user fa-fw" aria-hidden="true"></i> admin
                        </a>

                        <ul class="dropdown-menu dropdown-menu-end">
                            <li>
                                <a class="dropdown-item" href="/Admin">
                                    <i class="fa fa-desktop fa-fw" aria-hidden="true"></i> Dashboard
                                </a>
                            </li>


                            <li>
                                <a class="dropdown-item" href="/Admin/Users/Edit?returnUrl=%2F">
                                    <i class="far fa-address-card" aria-hidden="true"></i> Profile
                                </a>
                            </li>
                            <li>
                                <a class="dropdown-item" href="/ChangePassword?returnUrl=%2F">
                                    <i class="fa-solid fa-key" aria-hidden="true"></i> Change password
                                </a>
                            </li>
                            <li>
                                <form method="post" class="no-multisubmit" action="/Users/LogOff">
                                    <button type="submit" class="dropdown-item">
                                        <i class="fa-solid fa-sign-out-alt" aria-hidden="true"></i> Log off
                                    </button>
                                    <input name="__RequestVerificationToken" type="hidden"
                                        value="..." />
                                </form>
                            </li>

                        </ul>
                    </li>

                    </li>

To Reproduce

Steps to reproduce the behavior:

  1. Create a new site using SaaS template
  2. Log in as user created in setup
  3. Go to homepage and observe the page source is as above.

Expected behavior

I believe this is a matter of the shape needing a wrapper cleared, but I'm still learning my way with Shapes.

Screenshots

image

@hishamco
Copy link
Member

/cc @MikeAlhayek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants