Frontend assets are outdated

[Piedone]

Describe the bug

The assets_validation workflow didn't catch this, because it has a bug, but if you build the frontend assets then there will be changed files. This means that when you run OC, the client-side assets are actually outdated.

See a correctly failing assets_validation here.

Once #15619 is merged, assets_validation will be fixed.

To Reproduce

In the root of the repo:

1. npm install
2. gulp rebuild

Expected behavior

No files changed.

Also, we should run assets_validation as a CI workflow too, this shouldn't be just on-demand. So, add the following triggers to it:

on: 
  push:
    paths-ignore:
      - '**/*.md'
      - 'mkdocs.yml'
      - 'src/docs/**/*'
    branches: [ main ]
  pull_request:
    branches: [ main, release/** ]
concurrency:
  group: ${{ github.head_ref || github.run_id }}
  cancel-in-progress: true

Screenshots

[Piedone]

Is this maybe something you'd be interested in, @agriffard?

[BenedekFarkas]

Is the workflow intentionally not using paths instead of paths-ignore? I just added a similar workflow job in O1 and I didn't add any filtering there yet, but for O1 it would probably be just **.less and **.js, OC might be more complicated.

[Piedone]

I just copied that from the Main workflow, but it looks correct: we want the workflow to run on all main pushes except if the commit only changed the docs, since then it's pointless.

[MikeAlhayek]

@Piedone I am going over all the tagged PR with milestone 1.9. Why would this issue block 1.9? I mean we should be able to ship 1.9 without this issue, right?

I think this one should be tagged with 1.x so it does not block 1.9. Thoughts?

[Piedone]

Currently, we don't know how much the C# and Razor code is not in sync with JS and CSS. Bugs that are supposed to be fixed might not work, or we might have code with the opposite in the source files and the asset files (we've seen that).

So I don't think we should ship 1.9 without this, no.

[Piedone]

BTW I went through the recent bug issues without a milestone, looking for regressions since 1.8 (because those we should all fix before 1.9) but couldn't find any new ones.

[MikeAlhayek]

Once #15619 is merged, assets_validation will be fixed.

That referenced PR was merged. Do we still need to run gulp rebuild on a new branch and update all of out assets manually at least one time to catch up anything that was missed?

[Piedone]

That PR merged the assets_validation GitHub Actions workflow. So, it could now tell us that asset validation fails :). We still need to fix the assets, yes. This issue is about that.