Remove VersionOptions.AllVersions

[MarGraz]

For an explanation, see comments below from #16027 (comment). We should remove VersionOptions.AllVersions.

The original issue below is kept for context.

Describe the bug

The method _contentManager.GetAsync(model.ContentItemId, VersionOptions.AllVersions) fails to return any content items, whether published or draft. When debugging in Visual Studio with "Just my code" disabled, execution enters the condition else if (options.IsDraft || options.IsDraftRequired) in DefaultContentManager here.

I'm unsure why this condition is satisfied, given that my content item is published and the boolean IsDraft and IsDraftRequired are set to false.

Screenshots are provided for reference.

To Reproduce

Steps to reproduce the behavior:

1. Use Orchard Core 1.8.3
2. Activate the "Content Fields Indexing (SQL)" feature (I have it active)
3. Create a Content Item and publish it
4. In a controller, use IContentManager from dependency injection to retrieve the Content Item by its ID with VersionOptions.AllVersions set, like this: _contentManager.GetAsync(model.ContentItemId, VersionOptions.AllVersions)
5. Execute the code to verify whether a Content Item is returned

Expected behavior

A published or drafted Content Item must be returned when I set VersionOptions.AllVersions

Screenshots

My Content Item:

IsDraft and IsDraftRequired are false, why the condition is satisfied?

[Piedone]

Isn't this what #11433 addresses?

[Piedone]

A note for this and #11433 @hyzx86 about AllVersions :

• It's most possibly meant to let you fetch all past and the single current version of a content item.
• It isn't actually doing anything now, it's not used. But we can make it work, or remove it.
• It doesn't actually make sense for GetAsync(contentItemId, VersionOptions options): that method will always return at most a single content item, so it can't return all versions of a content item. That method should throw an exception with this input.
• It does make sense for GetAsync(IEnumerable<string> contentItemIds, VersionOptions options) though, since it returns multiple items anyway. However, this might get confusing there, when you get back N ContentItems, but those are mixed as versions and content items.

Also, there's no need for something like an AnyVersion or to change this to satisfy the expectations of this bug report, since Latest is already for that.

[sebastienros]

I suggest we remove the AllVersions option since it's not used, and not working, and the expectations wouldn't be fulfilled when you pass multiple content item ids.

If a user wants historical list of version they would use the ContentItemIndex to filter them. We could add a custom method that takes a simple query filter and would use the Load from DefaultContentManager to handle the lifecyle events.

[Piedone]

#16077 takes the make it work approach, with throwing in GetAsync(contentItemId, VersionOptions options) and returning all versions in GetAsync(IEnumerable<string> contentItemIds, VersionOptions options).

Any comments?