liquid script tag does not render custom attributes #16348

bashuss · 2024-06-19T15:46:45Z

Describe the bug

liquid template line
{% script name:"pdf.js", src:"/Vendor/pdfjs/build/pdf.js", type:"module", defer:"defer", at:"head", depends_on:"jQuery" %}

renderes in <head> as:

<script src="/t4h/OrchardCore.Resources/Scripts/jquery.min.js"></script>
<script src="/Vendor/pdfjs/build/pdf.js"></script>

, so defer and type attributes are missing.

When you look at the code of https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Resources/Liquid/ScriptTag.cs
it collects the custom attributes. Somewhere on the way to HTML, they get lost.

Orchard Core version

2.0.0-preview-18232

To Reproduce

Steps to reproduce the behavior:

Add this line to a backend template:
{% script name:"somelocalscript", src:"/somelocalscript.js", type:"module", defer:"defer", at:"head", depends_on:"jQuery" %}
Call a front end page that uses the template
check source code for the created script tag
Check if custom properties "type" and "defer" are there.

Edit: Not enough to reproduce: Please check this comment:
#16348 (comment)

Expected behavior

<script src="/t4h/OrchardCore.Resources/Scripts/jquery.min.js"></script>
<script src="/somelocalscript.js" type="module", defer="defer"></script>

The text was updated successfully, but these errors were encountered:

mdameer · 2024-06-19T18:40:39Z

@bashuss I can't reproduce this issue with the latest code from main, I think everything is rendered as expected, as you can see in this image:

bashuss · 2024-06-19T20:10:54Z

@mdameer What was the exact liquid code you used? Maybe I have a typo...
I just tried with the latest nightly build - still no success.

Piedone · 2024-06-19T20:14:21Z

Same here; maybe we fixed it in the two weeks since that preview version. I get this:

<script src="/blog2/OrchardCore.Resources/Scripts/jquery.min.js"></script>
<script defer="defer" src="/Vendor/pdfjs/build/pdf.js" type="module"></script>

With:

{% script name:"pdf.js", src:"/Vendor/pdfjs/build/pdf.js", type:"module", defer:"defer", at:"head", depends_on:"jQuery" %}

I used the Blog recipe, and put this into a template named Widget__Blockquote, created from the admin.

bashuss · 2024-06-20T07:33:36Z

Thanks for testing! I'll wait a while and try again.

bashuss · 2024-06-20T07:34:28Z

As it is ok for you, I'll reopen, if I cannot make it work within the next month. Not in a hurry here...

hishamco · 2024-06-20T09:17:13Z

Why this should be open if the issue not exist?

Piedone · 2024-06-20T12:17:29Z

Yeah, please just confirm, I wouldn't like to keep a dangling issue open.

bashuss · 2024-06-20T13:56:43Z

Is there a quick way to switch between full git checkout and nuget packages?
With a fresh git checkout of "main" and a new project it also works on my machine.

I would like a quick way to see, if the nuget to checkout makes the difference, or if I have to search for something specific in my project.

bashuss · 2024-06-20T13:56:51Z

Is there a quick way to switch between full git checkout and nuget packages?
With a fresh git checkout of "main" and a new project it also works on my machine.

I would like a quick way to see, if the nuget to checkout makes the difference, or if I have to search for something specific in my project.

Piedone · 2024-06-20T15:27:25Z

It's not quick, but you can configure a local NuGet folder and dotnet pack the latest OC source to it. Otherwise, you can simply reference the latest preview NuGet packages from Cloudsmith.

bashuss · 2024-06-21T09:46:47Z

Not sure if you meant that: I copied the OrchardCore.Cms.Web.csproj file and renamed it to OrchardCore.Cms.Web.Nuget.csproj, replaced the cms.Targets project reference by the preview nuget package a')nd configured a different build path ('/bin-nuget').
This allows to run the same code and AppData with source and with nuget.
Unfortunately everything works fine - so there must be something wrong specifically with my project.

The other difference I see between my project and the fresh checkout is, that the required jQuery has a cache busting version appended to the url, which is not present in my project.

<script src="/OrchardCore.Resources/Scripts/jquery.js?v=a4kg606ehDzlqOuGT25zpwTVCNBlY_nLGtlOpOZcMLg"></script> - in fresh checkout
<script src="/t4h/OrchardCore.Resources/Scripts/jquery.min.js"></script> - in my project

As there is also the difference between minified and non minified version, I thought, that the reason could be a difference between release and debug build. Trying to test this, I stumbled over this: #16358

Can you point me to the code that renders the script tag? I'd like to check, if there are any configurations, which may cause the difference between my project and the clean checkout.

Piedone · 2024-06-21T13:08:16Z

My only guess is that your theme has no reference to either OrchardCore.DisplayManagement or OrchardCore.ResourceManagement. If indeed, check if adding them will help.

You can start from here: https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.ResourceManagement/TagHelpers/ScriptTagHelper.cs

bashuss · 2024-06-21T14:33:10Z

My only guess is that your theme has no reference to either OrchardCore.DisplayManagement or OrchardCore.ResourceManagement. If indeed, check if adding them will help.

I thought, that it might be my theme, so I switched to different front end themes - no success within my project.
I guess it must either be an activated feature or some setting or code within my web app.

bashuss · 2024-06-21T15:44:21Z

My theme had used OrchardCore.ResourceManagement.Abstraction. I replaced it, but no change, as expected from the tests with other themes.
I tried in another tenant in the same application and it worked.

So it is a tenant specific setting or feature, that creates the problem.

Piedone · 2024-06-21T15:48:58Z

From this I can't help, sorry.

bashuss · 2024-06-21T18:30:44Z

Found the problem:
{% script name:"pdf.js", src:"/Vendor/pdfjs/build/pdf.js", type:"module", defer:"defer", at:"head", depends_on:"jQuery" %}

works fine, as long as no script depends on it.
As soon as you have a following

{% scriptblock name:"depending", depends_on:"pdf.js", at:"foot" %}
// some script
{% endscriptblock %}

the extra attributes are not rendered anymore. This also is the only thing that makes sense with the existing code - without have found the exact location of the problem yet.

Piedone · 2024-06-22T13:23:08Z

I don't think that code block makes sense, since you can't include an external script and add inline code at the same time.

We could throw an exception in this case.

bashuss · 2024-06-22T14:16:07Z

I don't understand your reasoning. You include one library script like pdf.js and then have a dependent custom script that works with it. This should be rather standard. Sure, I could write the code of the custom script in a .js file and host it with my app, but with the ability to create templates on the frontend, you may like to do something like this.

Also adding an inline script within a template allows the script to have code variations depending on the Model of the shape and the custom settings. In my case this provides an easy way to handle the pdf.worker.mjs url for pdfjsLib, which is initialized by passing the path to the lib and not by adding another script to the ResourceManagement. So when you have tenants with prefixes and some without, you can use liquid to always have the correct path.

SzymonSel · 2024-06-25T09:32:50Z

There's a missing clause in the ScriptTag.cs in the case when !string.IsNullOrEmpty(name) && string.IsNullOrEmpty(src).

bashuss added the bug 🐛 label Jun 19, 2024

Piedone added the needs author feedback label Jun 19, 2024

bashuss closed this as completed Jun 20, 2024

bashuss reopened this Jun 20, 2024

bashuss closed this as completed Jun 20, 2024

bashuss reopened this Jun 21, 2024

Piedone removed the needs author feedback label Jun 22, 2024

SzymonSel mentioned this issue Jun 25, 2024

Fix for case when src is not provided #16368

Merged

This was referenced Jul 1, 2024

Monthly community metrics report for 2024-06-01..2024-06-30 SGuidone/OrchardCore#45

Open

Monthly community metrics report for 2024-06-01..2024-06-30 #16387

Closed

sebastienros closed this as completed Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

liquid script tag does not render custom attributes #16348

liquid script tag does not render custom attributes #16348

bashuss commented Jun 19, 2024 •

edited

Loading

mdameer commented Jun 19, 2024

bashuss commented Jun 19, 2024 •

edited

Loading

Piedone commented Jun 19, 2024

bashuss commented Jun 20, 2024

bashuss commented Jun 20, 2024

hishamco commented Jun 20, 2024

Piedone commented Jun 20, 2024

bashuss commented Jun 20, 2024

bashuss commented Jun 20, 2024

Piedone commented Jun 20, 2024

bashuss commented Jun 21, 2024

Piedone commented Jun 21, 2024

bashuss commented Jun 21, 2024 •

edited

Loading

bashuss commented Jun 21, 2024

Piedone commented Jun 21, 2024

bashuss commented Jun 21, 2024

Piedone commented Jun 22, 2024

bashuss commented Jun 22, 2024 •

edited

Loading

SzymonSel commented Jun 25, 2024

liquid script tag does not render custom attributes #16348

liquid script tag does not render custom attributes #16348

Comments

bashuss commented Jun 19, 2024 • edited Loading

Describe the bug

Orchard Core version

To Reproduce

Expected behavior

mdameer commented Jun 19, 2024

bashuss commented Jun 19, 2024 • edited Loading

Piedone commented Jun 19, 2024

bashuss commented Jun 20, 2024

bashuss commented Jun 20, 2024

hishamco commented Jun 20, 2024

Piedone commented Jun 20, 2024

bashuss commented Jun 20, 2024

bashuss commented Jun 20, 2024

Piedone commented Jun 20, 2024

bashuss commented Jun 21, 2024

Piedone commented Jun 21, 2024

bashuss commented Jun 21, 2024 • edited Loading

bashuss commented Jun 21, 2024

Piedone commented Jun 21, 2024

bashuss commented Jun 21, 2024

Piedone commented Jun 22, 2024

bashuss commented Jun 22, 2024 • edited Loading

SzymonSel commented Jun 25, 2024

bashuss commented Jun 19, 2024 •

edited

Loading

bashuss commented Jun 19, 2024 •

edited

Loading

bashuss commented Jun 21, 2024 •

edited

Loading

bashuss commented Jun 22, 2024 •

edited

Loading