Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trumbowyg editor modals display in light mode while dark mode is active #16362

Closed
mdameer opened this issue Jun 21, 2024 · 5 comments
Closed
Labels
Milestone

Comments

@mdameer
Copy link
Contributor

mdameer commented Jun 21, 2024

Describe the bug

When dark mode is enabled, the Trumbowyg editor modals do not follow the dark theme and instead display in light mode. This inconsistency affects the user experience.

image

Orchard Core version

Latest code from main

To Reproduce

Steps to reproduce the behavior:

  1. Enable dark mode.
  2. Navigate to any content item that uses the Trumbowyg editor.
  3. Open the Insert link modal.
  4. Observe that the modal displays in light mode despite active dark mode.

Expected behavior

The Trumbowyg editor modal should adapt to the active theme and display in dark mode when dark mode is enabled.

@hishamco
Copy link
Member

I think there's a similar issue already there

@mdameer
Copy link
Contributor Author

mdameer commented Jun 22, 2024

@hishamco I found another issue regarding the Trumbowyg editor theme (#16137). I have a draft PR (#16356) that will address both, so for a clear history of resolved issues I created this one, also to discuss the ability to use the default Trumbowyg editor theme which already supports light/dark modes, and why we have _trumbowyg.scss? do we need it?

Orchard core
image

Trumbowyg default theme
image

@hishamco
Copy link
Member

I'm not sure why we need that file, but if your PR fixes both issues I never mind to use the default Trumbowysiwyg themes

@mdameer
Copy link
Contributor Author

mdameer commented Jun 22, 2024

I'm not sure why we need that file, but if your PR fixes both issues I never mind to use the default Trumbowysiwyg themes

Thanks @hishamco, switching to the component's default theme is now included in the PR

@sebastienros sebastienros added this to the 2.x milestone Jun 27, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants