Fix Wysiwyg/Trumbowyg editor colors when dark theme enabled #16356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested changes
Jun 21, 2024
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Trumbowyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Wysiwyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
hishamco
requested changes
Jun 22, 2024
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Trumbowyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Wysiwyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <[email protected]>
MikeAlhayek
requested changes
Jun 23, 2024
src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/trumbowyg.theme.js
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Trumbowyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Wysiwyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlField-Wysiwyg.Edit.cshtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
MikeAlhayek
requested changes
Jun 23, 2024
src/OrchardCore.Modules/OrchardCore.ContentFields/ResourceManagementOptionsConfiguration.cs
Show resolved
Hide resolved
|
Why the changes increased to 35 files :) |
Most of the changes involve moving static files to the correct folders. If you prefer, I can undo any unrelated changes. The main change is to abstract the theme manager to be reusable by the admin and other themes and ensure the Trumbowyg editor adheres to theme mode changes. |
sebastienros
approved these changes
Jun 27, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16137, #16362
This PR fixes the Trumbowyg editor issues in dark mode by switching to the component's default theme for both light and dark modes. It also keeps a few custom CSS classes to ensure the borders match Orchard's styles.