Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if OrchardCore.Layers.AdminController.Index(LayersIndexViewModel) can be refactored #16570

Closed
sebastienros opened this issue Aug 15, 2024 · 3 comments · Fixed by #16571
Closed
Labels
Milestone

Comments

@sebastienros
Copy link
Member

There is an argument in this method which might not be necessary.

Description in this comment:
#16567 (comment)

@sebastienros
Copy link
Member Author

Might even be able to remove the whole action.

@sebastienros sebastienros added this to the 2.x milestone Aug 15, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@MikeAlhayek
Copy link
Member

Yes I don't think the Post Action method is needed. It should be removed. and if you think it could break someone, we should remove it before releasing 2.0 otherwise we would have to wait for 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants