Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duration shape to support RTL languages #16742

Closed
sebastienros opened this issue Sep 17, 2024 · 2 comments · Fixed by #16745
Closed

Fix Duration shape to support RTL languages #16742

sebastienros opened this issue Sep 17, 2024 · 2 comments · Fixed by #16745
Labels
Milestone

Comments

@sebastienros
Copy link
Member

In DateTimeShapes

We can't concatenate localized strings because RTL and other languages might not accept this order. Localized strings should be a single string with arguments. However with durations we need multiple variables to define the plurals, which we can't do (too many combinations), so we need to choose a form that will work in all cases.

Suggestions, with the example of 2 days and 3 minutes.

  1. 2 different strings
    When it's not a single unit: "approximately 2 days" and for single units: "2 days"
  2. Only use the biggest unit: "2 days"

We will ignore the smaller parts of the duration.

@MikeAlhayek MikeAlhayek added this to the 2.1 milestone Sep 17, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@sebastienros
Copy link
Member Author

@MikeAlhayek note that the actual HTML should display the simple translated text, and have a tooltip with the actual duration in an official dotnet format. Check the GH commits history that shows when a commit was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants