Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure email provider can't handle display names in email addresses #16888

Closed
BenedekFarkas opened this issue Oct 15, 2024 · 1 comment · Fixed by #16889
Closed

Azure email provider can't handle display names in email addresses #16888

BenedekFarkas opened this issue Oct 15, 2024 · 1 comment · Fixed by #16889
Assignees
Labels
Milestone

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Oct 15, 2024

Describe the bug

The Azure email provider surfaces an exception from Azure.Communication.Email when it passes in email addresses that include a display name to the constructor of the EmailAddress class in AzureEmailProviderBase.

Orchard Core version

2.0

To Reproduce

  1. Configure the application to use Azure Email Communication Services and enable the Orchard.Email.Azure feature.
  2. Use the email test settings screen (/Admin/Email/Test) and provide an email address in the Display Name <[email protected]> format in any of the fields that accept an email address.

Expected behavior

The provider should deconstruct such email addresses and use the other overload of the AzureEmailProviderBase constructor which accepts a separate display name parameter too.
Orchard.Email.Smtp handles this correctly, because MimeKit takes care of deconstructing such email addresses.

The display name for the sender field is simply dropped, because the SDK doesn't support it: Azure/azure-sdk-for-net#43847

Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants