Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Users are being able to register a new account even when DisableNewRegistrations is enabled #17048

Closed
MikeAlhayek opened this issue Nov 23, 2024 · 1 comment · Fixed by #17050
Closed

External Users are being able to register a new account even when DisableNewRegistrations is enabled #17048

MikeAlhayek opened this issue Nov 23, 2024 · 1 comment · Fixed by #17050
Labels
bug 🐛 security
Milestone
3.0

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

When using external authentication feature, users login from external providers still create a new account even when the setting DisableNewRegistrations is set to true.

Orchard Core version

v2.1

To Reproduce

  1. Enable any external authentication provider feature.
  2. Set DisableNewRegistrations to true in the External Authentication settings.
  3. Try to login using the external provider.

Expected behavior

Users should not be able to register if DisableNewRegistrations is set to true.
@MikeAlhayek
Copy link
Member Author

I am working on a PR for this.

MikeAlhayek added a commit that referenced this issue Nov 23, 2024
@MikeAlhayek
Prevent External Users Registration
c065fc6 
Fix #17048
@MikeAlhayek MikeAlhayek mentioned this issue Nov 23, 2024
Merged
@MikeAlhayek MikeAlhayek modified the milestones: 3.0, 2.1 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 security
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Prevent External Users Registration OrchardCMS/OrchardCore
1 participant
@MikeAlhayek