Added feature ID in braces to feature name for clarity #10391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoAltinet
commented
Oct 1, 2021
src/OrchardCore.Modules/OrchardCore.Taxonomies/Liquid/TaxonomyTermFilter.cs
Outdated
Show resolved
Hide resolved
|
Can you send a screenshot with the changes? Looks like a good idea though |
|
Any chance of a screenshot for this? I think the change would be really useful |
|
Hey Dean, sorry for delay i've been terribly busy launching an Orchard site:). I'll have one ready tomorrow. I have a bunch of other ideas and suggestions that i gathered migrating an old site to Orchard |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Features/Views/Admin/Features.cshtml
|
I checked out the PR, going over old ones, and this would indeed be quite useful. So, I fixed the merge conflict. Old UI:
New UI with @brunoAltinet's changes:
After I tweaked it with
|
Piedone
changed the title
deanmarcussen
approved these changes
Jan 17, 2024
Skrypt
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Added feature id in braces to feature name for clarity * Update TaxonomyTermFilter.cs * Adding code formatting --------- Co-authored-by: Zoltán Lehóczky <[email protected]>
hishamco
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Added feature id in braces to feature name for clarity * Update TaxonomyTermFilter.cs * Adding code formatting --------- Co-authored-by: Zoltán Lehóczky <[email protected]>
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
) * Added feature id in braces to feature name for clarity * Update TaxonomyTermFilter.cs * Adding code formatting --------- Co-authored-by: Zoltán Lehóczky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one got me banging head against the wall for hours. I assumed that the feature is calle OrchardCore.Media.Azure, but it's actually called OrchardCore.Media.Azure.Storage. There's no way to see that unless you have OrchardCore source open, and i'm explictliy building against packages. We need to show feature id somewhere, somehow.